Skip to content

feat: include override-affected flag metadata - #79

Merged
kinyoklion merged 1 commit into
mainfrom
devin/1794523249-override-affected
Nov 16, 2026
Merged

kinyoklion merged 1 commit into
mainfrom
devin/1794523249-override-affected

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions (local run on Python 3.12 only; CI covers the matrix)

Related issues

Implements OFP 1.1.0 requirements 3.3.1–3.3.2 (launchdarkly/sdk-specs#284): flag metadata carries overrideAffected: true when the evaluation reason marks the evaluation as override-affected, and omits it otherwise.

Describe the solution you've provided

  • ResolutionDetailsConverter copies reason["overrideAffected"] into flag metadata as overrideAffected: True only when it is True, following the existing inExperiment handling and matching js-core's translateResult.ts.
  • Raises the launchdarkly-server-sdk floor from >=9.18.3 to >=9.21.0, the first release that sets overrideAffected on the reason.
  • README: new feature-matrix row and a overrideAffected row in the Flag Metadata table.
  • Unit tests cover the true case and absent/false/non-boolean values.

Describe alternatives you've considered

Keeping the 9.18.3 floor and relying on the key just being absent on older SDKs. The code would behave the same, but the provider could not reliably offer the feature, so the floor is raised instead.

Additional context

make lint test: mypy clean, 97 tests passed.


OpenFeature Maintainer opened this PR for Ryan

Implemented in session Add overrideAffected metadata to Python provider
Review with Devin · Open in Devin Desktop



Devin Review

SDK-3580


Note

Overview
Adds OpenFeature 1.1 override-affected flag metadata: when LaunchDarkly’s evaluation reason has overrideAffected: true, ResolutionDetailsConverter now includes overrideAffected: True in flag metadata (same include-only-when-True pattern as inExperiment).

The minimum launchdarkly-server-sdk dependency is raised from 9.18.3 to 9.21.0, where that reason field is available. README feature matrix and Flag Metadata docs are updated, and unit tests cover both the true case and when the field is absent, false, or non-boolean.

Reviewed by Cursor Bugbot for commit da29872. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@kinyoklion
kinyoklion marked this pull request as ready for review November 12, 2026 23:15
@kinyoklion
kinyoklion requested a review from a team as a code owner November 12, 2026 23:15
@kinyoklion
kinyoklion merged commit 08c8f5d into main Nov 16, 2026
22 checks passed
@kinyoklion
kinyoklion deleted the devin/1794523249-override-affected branch November 16, 2026 22:15
kinyoklion pushed a commit that referenced this pull request Nov 18, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.10.0](0.9.1...0.10.0)
(2026-11-17)


### Features

* include override-affected flag metadata
([#79](#79))
([08c8f5d](08c8f5d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants