Repository navigation
feat: include override-affected flag metadata - #79
Merged
Merged
Conversation
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
kinyoklion
marked this pull request as ready for review
November 12, 2026 23:15
keelerm84
approved these changes
Nov 16, 2026
kinyoklion
pushed a commit
that referenced
this pull request
Nov 18, 2026
🤖 I have created a release *beep* *boop* --- ## [0.10.0](0.9.1...0.10.0) (2026-11-17) ### Features * include override-affected flag metadata ([#79](#79)) ([08c8f5d](08c8f5d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Implements OFP 1.1.0 requirements 3.3.1–3.3.2 (launchdarkly/sdk-specs#284): flag metadata carries
overrideAffected: truewhen the evaluation reason marks the evaluation as override-affected, and omits it otherwise.Describe the solution you've provided
ResolutionDetailsConvertercopiesreason["overrideAffected"]into flag metadata asoverrideAffected: Trueonly when it isTrue, following the existinginExperimenthandling and matching js-core'stranslateResult.ts.launchdarkly-server-sdkfloor from>=9.18.3to>=9.21.0, the first release that setsoverrideAffectedon the reason.overrideAffectedrow in the Flag Metadata table.Describe alternatives you've considered
Keeping the 9.18.3 floor and relying on the key just being absent on older SDKs. The code would behave the same, but the provider could not reliably offer the feature, so the floor is raised instead.
Additional context
make lint test: mypy clean, 97 tests passed.OpenFeature Maintainer opened this PR for Ryan
Implemented in session Add overrideAffected metadata to Python provider
Review with Devin · Open in Devin Desktop
SDK-3580
Note
Overview
Adds OpenFeature 1.1 override-affected flag metadata: when LaunchDarkly’s evaluation reason has
overrideAffected: true,ResolutionDetailsConverternow includesoverrideAffected: Truein flag metadata (same include-only-when-Truepattern asinExperiment).The minimum
launchdarkly-server-sdkdependency is raised from 9.18.3 to 9.21.0, where that reason field is available. README feature matrix and Flag Metadata docs are updated, and unit tests cover both the true case and when the field is absent, false, or non-boolean.Reviewed by Cursor Bugbot for commit da29872. Bugbot is set up for automated code reviews on this repo. Configure here.